Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
bugzilla
Project
Project
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
etersoft
bugzilla
Commits
f1973062
You need to sign in or sign up before continuing.
Commit
f1973062
authored
Oct 07, 2010
by
Max Kanat-Alexander
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Bug 600495: Make the "chfieldto" query parameter work all by itself, again.
r=mkanat, a=mkanat (module owner)
parent
af2f8916
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
5 deletions
+18
-5
Search.pm
Bugzilla/Search.pm
+11
-5
FieldTestNormal.pm
xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
+7
-0
No files found.
Bugzilla/Search.pm
View file @
f1973062
...
...
@@ -1309,14 +1309,20 @@ sub _special_parse_chfield {
# if there is a "from" date specified. It doesn't conflict with
# searching [Bug creation], because a bug's delta_ts is set to
# its creation_ts when it is created. So this just gives the
# database an additional index to possibly choose.
#
# It's not safe to do it for "to" dates, though--"chfieldto" means
# "a field that changed before this date", and delta_ts could be either
# later or earlier than that.
# database an additional index to possibly choose, on a table that
# is smaller than bugs_activity.
if
(
$date_from
ne
''
)
{
push
(
@charts
,
[
'delta_ts'
,
'greaterthaneq'
,
$date_from
]);
}
# It's not normally safe to do it for "to" dates, though--"chfieldto" means
# "a field that changed before this date", and delta_ts could be either
# later or earlier than that, if we're searching for the time that a field
# changed. However, chfieldto all by itself, without any chfieldvalue or
# chfield, means "just search delta_ts", and so we still want that to
# work.
if
(
$date_to
ne
''
and
!
@fields
and
$value_to
eq
''
)
{
push
(
@charts
,
[
'delta_ts'
,
'lessthaneq'
,
$date_to
]);
}
# Basically, we construct the chart like:
#
...
...
xt/lib/Bugzilla/Test/Search/FieldTestNormal.pm
View file @
f1973062
...
...
@@ -74,6 +74,13 @@ sub search_params {
return
{
chfield
=>
$field
,
$ch_param
=>
$value
};
}
if
(
$field
eq
'delta_ts'
and
$operator
eq
'greaterthaneq'
)
{
return
{
chfieldfrom
=>
$value
};
}
if
(
$field
eq
'delta_ts'
and
$operator
eq
'lessthaneq'
)
{
return
{
chfieldto
=>
$value
};
}
if
(
$field
eq
'deadline'
and
$operator
eq
'greaterthaneq'
)
{
return
{
deadlinefrom
=>
$value
};
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment