Commit f6f5b966 authored by Byron Jones's avatar Byron Jones

Bug 930867: background bugmail generation throws a "Can't store CODE items"…

Bug 930867: background bugmail generation throws a "Can't store CODE items" error on dep_only changes r=sgreen, a=sgreen
parent ad2cdcdf
...@@ -383,11 +383,14 @@ sub enqueue { ...@@ -383,11 +383,14 @@ sub enqueue {
# we need to flatten all objects to a hash before pushing to the job queue. # we need to flatten all objects to a hash before pushing to the job queue.
# the hashes need to be inflated in the dequeue method. # the hashes need to be inflated in the dequeue method.
$vars->{bug} = _flatten_object($vars->{bug}); $vars->{bug} = _flatten_object($vars->{bug});
$vars->{to_user} = $vars->{to_user}->flatten_to_hash; $vars->{to_user} = _flatten_object($vars->{to_user});
$vars->{changer} = _flatten_object($vars->{changer}); $vars->{changer} = _flatten_object($vars->{changer});
$vars->{new_comments} = [ map { _flatten_object($_) } @{ $vars->{new_comments} } ]; $vars->{new_comments} = [ map { _flatten_object($_) } @{ $vars->{new_comments} } ];
foreach my $diff (@{ $vars->{diffs} }) { foreach my $diff (@{ $vars->{diffs} }) {
$diff->{who} = _flatten_object($diff->{who}); $diff->{who} = _flatten_object($diff->{who});
if (exists $diff->{blocker}) {
$diff->{blocker} = _flatten_object($diff->{blocker});
}
} }
Bugzilla->job_queue->insert('bug_mail', { vars => $vars }); Bugzilla->job_queue->insert('bug_mail', { vars => $vars });
} }
...@@ -404,6 +407,9 @@ sub dequeue { ...@@ -404,6 +407,9 @@ sub dequeue {
$vars->{new_comments} = [ map { Bugzilla::Comment->new_from_hash($_) } @{ $vars->{new_comments} } ]; $vars->{new_comments} = [ map { Bugzilla::Comment->new_from_hash($_) } @{ $vars->{new_comments} } ];
foreach my $diff (@{ $vars->{diffs} }) { foreach my $diff (@{ $vars->{diffs} }) {
$diff->{who} = Bugzilla::User->new_from_hash($diff->{who}); $diff->{who} = Bugzilla::User->new_from_hash($diff->{who});
if (exists $diff->{blocker}) {
$diff->{blocker} = Bugzilla::Bug->new_from_hash($diff->{blocker});
}
} }
# generate bugmail and send # generate bugmail and send
MessageToMTA(_generate_bugmail($vars), 1); MessageToMTA(_generate_bugmail($vars), 1);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment