Skip to content

bugzilla
bugzilla
Commit f9a3ffaf authored by Frédéric Buclin's avatar Frédéric Buclin
Browse files
Options

Bug 1232190: FlagType.create should require the user to be logged in

r=dkl
parent fbd124bf
Hide whitespace changes
Inline Side-by-side
Showing with 6 additions and 14 deletions
Bugzilla/API/1_0/Resource/FlagType.pm
View file @ f9a3ffaf
......@@ -114,11 +114,9 @@ sub get {
sub create {
my ($self, $params) = @_;
my $user = Bugzilla->login(LOGIN_REQUIRED);
my $dbh = Bugzilla->dbh;
my $user = Bugzilla->user;
Bugzilla->user->in_group('editcomponents')
$user->in_group('editcomponents')
|| scalar(@{$user->get_products_by_permission('editcomponents')})
|| ThrowUserError("auth_failure", { group => "editcomponents",
action => "add",
......@@ -174,11 +172,9 @@ sub create {
sub update {
my ($self, $params) = @_;
my $dbh = Bugzilla->dbh;
my $user = Bugzilla->user;
my $user = Bugzilla->login(LOGIN_REQUIRED);
Bugzilla->login(LOGIN_REQUIRED);
$user->in_group('editcomponents')
|| scalar(@{$user->get_products_by_permission('editcomponents')})
|| ThrowUserError("auth_failure", { group => "editcomponents",
......
Bugzilla/WebService/FlagType.pm
View file @ f9a3ffaf
......@@ -61,11 +61,9 @@ sub get {
sub create {
my ($self, $params) = @_;
my $user = Bugzilla->login(LOGIN_REQUIRED);
my $dbh = Bugzilla->dbh;
my $user = Bugzilla->user;
Bugzilla->user->in_group('editcomponents')
$user->in_group('editcomponents')
|| scalar(@{$user->get_products_by_permission('editcomponents')})
|| ThrowUserError("auth_failure", { group => "editcomponents",
action => "add",
......@@ -121,11 +119,9 @@ sub create {
sub update {
my ($self, $params) = @_;
my $dbh = Bugzilla->dbh;
my $user = Bugzilla->user;
my $user = Bugzilla->login(LOGIN_REQUIRED);
Bugzilla->login(LOGIN_REQUIRED);
$user->in_group('editcomponents')
|| scalar(@{$user->get_products_by_permission('editcomponents')})
|| ThrowUserError("auth_failure", { group => "editcomponents",
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment