Commit fd87911b authored by lpsolit%gmail.com's avatar lpsolit%gmail.com

Bug 419188: [SECURITY] email_in.pl lets you set the changer as @reporter instead…

Bug 419188: [SECURITY] email_in.pl lets you set the changer as @reporter instead of only checking the "From" header - Patch by Fré©ric Buclin <LpSolit@gmail.com> r=mkanat a=LpSolit
parent 6d7d31d0
......@@ -106,6 +106,16 @@ sub parse_mail {
if ($line =~ /^@(\S+)\s*=\s*(.*)\s*/) {
$current_field = lc($1);
# It's illegal to pass the reporter field as you could
# override the "From:" field of the message and bypass
# authentication checks, such as PGP.
if ($current_field eq 'reporter') {
# We reset the $current_field variable to something
# post_bug and process_bug will ignore, in case the
# attacker splits the reporter field on several lines.
$current_field = 'illegal_field';
next;
}
$fields{$current_field} = $2;
}
else {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment