r,a=justdave

quietly_check_login()/confirm_login() calls.  Cleans up callsites
(consisting of most of our CGIs), swapping (where appropriate) for calls
to Bugzilla->login. Patch by Teemu Mannermaa <wicked@etlicon.fi>.
r=bbaetz, kiko. a=justdave.

Patch for bug 237369: implement relatively simple changes from %FORM to $cgi->param variable; patch by Teemu Mannermaa <wicked@etlicon.fi>; r=kiko, justdave; a=justdave.

Bug 186130 - collectstats.pl doesn't work if 'requirelogin' set. Patch by gerv; r=bbaetz, a=justdave.

Bug 221900: duplicates.cgi query fails if more than one product selected; patch by chaduv <caduvall@glue.umd.edu>; r=gerv; a=justdave.

r=joel, a=justdave

r=gerv, a=justdave

Bug 192677: Add new test to flag failure-to-filter situations in the templates, and correct the XSS holes that were discovered as a
result of it.
Patch by Gervase Markham <gerv@mozilla.org>
r= myk, bbaetz, justdave
a= justdave

r=gerv
a=justdave

r=justdave
a=justdave

r=gerv, justdave
a=justdave

r=justdave, myk, joel, preed
a=justdave

original patch iteration by gerv, change to use Bugzilla:Search by me
r=myk, a=justdave

Bug 173808 - Use of uninitialized value in subtraction (-) at duplicates.cgi line 133. Patch by gerv; r=bbaetz.

r=bbaetz, gerv

Bug 146495 - clean up format ambiguities. We now have separate "format" and "ctype" parameters. Also fixes bug 140513, bug 143604, and bug 148133. Patch by gerv; r=myk.

Bug 167978 - Fix Throw*Error l10n regressions and add a test to catch more. Patch by gerv; r=bbaetz.

r=joel x2

Initial attempt by jake@bugzilla.org, updated by me
r=joel, preed

Bug 155584 - Opening duplicates.cgi with no frequent bugs causes SQL syntax error. Patch by gerv; r=bbaetz.

Bug 151281 - change duplicates.cgi to make one query instead of several thousand. Patch by gerv; r=myk, bbaetz.

r=gerv, myk

Patch by Brad Baetz <bbaetz@student.usyd.edu.au>
r= jake, justdave

Also fixes seeing bugs in the buglist (bug 95024), dependancy lists,
tooltips, duplicates, and everywhere else I could see which checked group
bugs.groupset == 0.

Also fxed bug 101560, by clearing BASH_ENV

r=myk,justdave

Patch by Gervase Markham <gerv@mozilla.org>
r= justdave@syndicomm.com

Patch by Gervase Markham <gervase.markham@univ.ox.ac.au>
r= justdave@syndicomm.com

Bullshit checkin to add the fact that the previous changes also include the final fix for bug 72721.  I am a buckethead

Fix for bug 72721 (duplicates.cgi performs poorly with lots of bugs) and bug 69054 (DB_File not portable): dependence on DB_File removed, now uses AnyDBM_File which comes standard with Perl.  Duplicates.cgi now runs its queries against the shadow database if it's available, among many other improvements.
Patch by gervase.markham@univ.ox.ac.uk (Gervase Markham)
r= justdave

Checking in Jake's <jake@acutex.net> interim patches from bug 30694. Bugzilla was showing bug summaries to everyone, even if they didn't have permission to view the bug. Jake's quick solution is to not display the bug at all if it is in a group no matter who is viewing it. The correct solution would be display the  summary if the viewer had the proper permissions.