• Max Kellermann's avatar
    decoder/flac: move the SubmitData() call out of the callback · 026aef74
    Max Kellermann authored
    This addresses two problems:
    
    1. the libFLAC write callback had to send an error status to its
    caller when SubmitData() returned a command; this disrupted libFLAC
    and the resulting command could not be used for anything;
    
    2. the libFLAC function FLAC__stream_decoder_seek_absolute() also
    calls the write callback, but its result cannot be used, because
    seeking is still in progress, so we lose all data from one FLAC frame.
    By moving the SubmitData() call until after CommandFinished(), we
    avoid losing this data.  This fixes another part of #113
    026aef74
FlacDecoderPlugin.cxx 9.86 KB