• Pete Beardmore's avatar
    MultipleOutputs: ensure input_audio_format is zero-initialised · d0cd98a6
    Pete Beardmore authored
    -fixes SIGABRT when mpd is started from a previously paused state
    -regression introduced by commit: f5a923b9:
    'OutputAll: convert to class, move instance to class Partition'
    
    -input_audio_format was previously declared using the static modifier
    ensuring it was zero-initialised by default
    -the current default-initialised input_audio_format contains garbage at
    runtime which allows the AudioFormat.IsDefined() 'fail fast' test in
    MultipleOutputs::Update to pass and the SIGABRT follows in
    AudioOutput::Open when passed the invalid input_audio_format struct
    -switching AudioFormat.IsDefined() for AudioFormat.IsValid() is an
    alternative workaround
    d0cd98a6
MultipleOutputs.cxx 9.21 KB