• Eric Wong's avatar
    Revert leaks from r4311, and also the leak fixes as a result of that · 6459b3ee
    Eric Wong authored
    utf8ToFsCharset() and fsCharsetToUtf8() got very broken in r4311, and
    resulted in several commits to fix those leaks.  Unfortunately, not all
    of those newly introduced leaks were fixed, nor was the result pretty.
    
    Also, fixed a double-free in lsPlaylists().  This is very hard
    to trigger (and therefore exploit) at the moment because we
    check printDirectoryInfo() beforehand.
    
    Intended behavior for utf8ToFsCharset() and fsCharsetToUtf8() as
    God^H^H^Hshank originally intended is now documented in path.h
    to prevent future errors like this.
    
    mpd could still use some good valgrind testing before the 0.12.0
    release.
    
    <plug>In addition to reducing heap fragmentation, malloc
    reductions from mpd-ke greatly reduces the chance of leaks from
    happening due to programming errors.</plug>
    
    git-svn-id: https://svn.musicpd.org/mpd/trunk@4639 09075e82-0dd4-0310-85a5-a0d7c8717e4f
    6459b3ee
decode.c 17.1 KB