• Vitaly Ostrosablin's avatar
    Make volume changes to apply to disabled software mixers. · ac060889
    Vitaly Ostrosablin authored
    Move audio output state check ahead of mixer check and force volume
    applying even for disabled software mixed outputs.
    
    This fixes incorrect software mixer volume that used to occur when
    volume was changed while output being disabled.
    
    This is easily reproduced with following sequence of commands on
    multi-output software mixed MPD setup.
    
     mpc volume 38; mpc disable 3; mpc volume 88; mpc enable 3
    
    On current MPD, following commands would result in output 3 playing at
    volume 38, while all other enabled outputs would play at volume
    88. Moreover, global volume would display average of outputs real
    volumes. In my case, it's 75.
    
    After applying this patch, following commands would produce expected
    behavior. All outputs play at expected (88) volume. And volume is
    correctly displayed as 88.
    
    Closes https://github.com/MusicPlayerDaemon/MPD/issues/1423
    
    Signed-off-by: Vitaly Ostrosablin tmp6154@yandex.ru
    Signed-off-by: 's avatarVitaly Ostrosablin <tmp6154@yandex.ru>
    ac060889
MixerAll.cxx 3.46 KB