• Terry's avatar
    mp4: fix potential integer overflow bug in the mp4_decode() function · 79a14c9a
    Terry authored
    A crafted mp4 file could cause an integer overflow in mp4_decode
    function in src/inputPlugins/mp4_plugin.c.  mp4ff_num_samples()
    function returns some tainted value. sizeof(float) * numSamples is an
    integer overflow operation if numSamples is too huge, so xmalloc will
    allocate a small memory region.  I constructe a mp4 file, and use
    faad2 to open the file. mp4ff_num_samples() returns -1. So I think mpd
    bears from the same problem.
    79a14c9a
mp4_plugin.c 10.2 KB