• Max Kellermann's avatar
    *: remove "pure" and "const" attributes from throwing functions · 788e3b31
    Max Kellermann authored
    The "pure" and "const" attributes are not so well-defined, and a
    recent clang version implements an optimization which pushes the
    definition's boundary beyond what I believed it was.  clang now
    assumes that functions declared "pure" cannot throw exceptions, even
    if they lack the "noexcept" specification.
    
    When compiled with this new clang version, MPD will crash randomly if
    an exception happens to get thrown by such as "pure" function
    (https://github.com/MusicPlayerDaemon/MPD/issues/41).
    
    This commit removes all such misplaced "pure" and "const" attributes,
    closing #41.
    788e3b31
SongSticker.hxx 2.42 KB