• Eric Wong's avatar
    interface/connection malloc reductions from mpd-ke · 4cf5d04c
    Eric Wong authored
    This patch massively reduces the amount of heap allocations at
    the interface/command layer.  Most commands with minimal output
    should not allocate memory from the heap at all.  Things like
    repeatedly polling status, currentsong, and volume changes
    should be faster as a result, and more importantly, not a source
    of memory fragmentation.
    
    These changes should be safe in that there's no way for a
    remote-client to corrupt memory or otherwise do bad stuff to
    MPD, but an extra set of eyes to review would be good.  Of
    course there's never any warranty :)
    
    No longer do we use FILE * structures in the interface, which means
    we don't have to allocate any new memory for most connections.
    
    Now, before you go on about losing the buffering that FILE *
    +implies+, remember that myfprintf() never took advantage of
    any of the stdio buffering features.
    
    To reduce the diff and make bugs easier to spot in the diff,
    I've kept myfprintf in places where we write to files (and not
    network interfaces).  Expect myfprintf to go away entirely soon
    (we'll use fprintf for writing regular files).
    
    git-svn-id: https://svn.musicpd.org/mpd/trunk@4483 09075e82-0dd4-0310-85a5-a0d7c8717e4f
    4cf5d04c
ls.h 1.44 KB