encoder/lame: explicitly configure the output sample rate

When you don't explicitly set an output sample rate, liblame tries to guess an output sample rate from the input sample rate. You would think that this "guessing" consists of just setting both equal, but that is not the case. For 44.1kHz at 96kbit/s, liblame chooses 32kHz. This patch explicitly configures the output sample rate, to stop the bad guessing.

encoder/lame: explicitly configure the output sample rate
0022fb10 · Max Kellermann · 4f2d67df · 0022fb10 · 0022fb10
Commit 0022fb10 authored Jan 07, 2011 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

NEWS NEWS +2 -0

lame_encoder.c src/encoder/lame_encoder.c +7 -0

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.15.16 (2010/??/??)
+* encoders:
+  - lame: explicitly configure the output sample rate


 ver 0.15.15 (2010/11/08)

--- a/src/encoder/lame_encoder.c
+++ b/src/encoder/lame_encoder.c
@@ -169,6 +169,13 @@ lame_encoder_setup(struct lame_encoder *encoder, GError **error)
 		return false;
 	}

+	if (0 != lame_set_out_samplerate(encoder->gfp,
+					 encoder->audio_format.sample_rate)) {
+		g_set_error(error, lame_encoder_quark(), 0,
+			    "error setting lame out sample rate");
+		return false;
+	}
+
 	if (0 > lame_init_params(encoder->gfp)) {
 		g_set_error(error, lame_encoder_quark(), 0,
 			    "error initializing lame params");