flac_plugin: revert the performance optimization we did a while ago

the performance optimization was broken for big-endian architectures. mpd-uclinux is doing using a slightly different optimization to flacWrite() that we may end up using here in the future. git-svn-id: https://svn.musicpd.org/mpd/trunk@3753 09075e82-0dd4-0310-85a5-a0d7c8717e4f

flac_plugin: revert the performance optimization we did a while ago
0153a789 · Eric Wong · 63475b5a · 0153a789
Commit 0153a789 authored Dec 31, 2005 by Eric Wong
Hide whitespace changes
Inline Side-by-side

Showing with 19 additions and 23 deletions

flac_plugin.c src/inputPlugins/flac_plugin.c +19 -23

No files found.
--- a/src/inputPlugins/flac_plugin.c
+++ b/src/inputPlugins/flac_plugin.c
@@ -407,11 +407,12 @@ FLAC__StreamDecoderWriteStatus flacWrite(const FLAC__SeekableStreamDecoder *dec,
 {
 	FlacData * data = (FlacData *)vdata;
 	FLAC__uint32 samples = frame->header.blocksize;
-	int c_samp;
+	FLAC__uint16 u16;
-	int c_chan;
+	unsigned char * uc;
+	int c_samp, c_chan, d_samp;
+	int i;
 	float timeChange;
 	FLAC__uint64 newPosition = 0;
-	const int bytesPerSample = data->dc->audioFormat.bits/8;
 	timeChange = ((float)samples)/frame->header.sample_rate;
 	data->time+= timeChange;
@@ -423,27 +424,22 @@ FLAC__StreamDecoderWriteStatus flacWrite(const FLAC__SeekableStreamDecoder *dec,
 	}
 	data->position = newPosition;
-	for(c_samp = 0; c_samp < frame->header.blocksize; c_samp++) {
+	for(c_samp = d_samp = 0; c_samp < frame->header.blocksize; c_samp++) {
-		for(c_chan = 0; c_chan < frame->header.channels; c_chan++) {
+		for(c_chan = 0; c_chan < frame->header.channels; 
-#ifdef WORDS_BIGENDIAN
+				c_chan++, d_samp++) {
-			memcpy(data->chunk+data->chunk_length,
+			u16 = buf[c_chan][c_samp];
-			       &buf[c_chan][c_samp]+4-bytesPerSample, 
+			uc = (unsigned char *)&u16;
-			       bytesPerSample);
+			for(i=0;i<(data->dc->audioFormat.bits/8);i++) {
-			data->chunk_length+=bytesPerSample;
+				if(data->chunk_length>=FLAC_CHUNK_SIZE) {
-#else
+					if(flacSendChunk(data)<0) {
-			memcpy(data->chunk+data->chunk_length,
+						return FLAC__STREAM_DECODER_WRITE_STATUS_ABORT;
-			       &buf[c_chan][c_samp], bytesPerSample);
+					}
-			data->chunk_length+=bytesPerSample;
+					data->chunk_length = 0;
-#endif
+					if(data->dc->seek) {
-			if(FLAC_CHUNK_SIZE-data->chunk_length < bytesPerSample) 
+						return FLAC__STREAM_DECODER_WRITE_STATUS_CONTINUE;
-			{
+					}
-				if(flacSendChunk(data)<0) {
-					return FLAC__STREAM_DECODER_WRITE_STATUS_ABORT;
-				}
-				data->chunk_length = 0;
-				if(data->dc->seek) {
-					return FLAC__STREAM_DECODER_WRITE_STATUS_CONTINUE;
 				}
+				data->chunk[data->chunk_length++] = *(uc++);
 			}
 		}
 	}