Queue: ModifyAtOrder() does not increment version

Leave that to the caller, allowing it to modify multiple items at a time.

Queue: ModifyAtOrder() does not increment version
03b57df6 · Max Kellermann · 4de3b6dc · 03b57df6 · 03b57df6 · 03b57df6
Commit 03b57df6 authored Oct 22, 2013 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

Playlist.cxx src/Playlist.cxx +1 -0

Queue.cxx src/Queue.cxx +0 -2

Queue.hxx src/Queue.hxx +2 -1

No files found.
--- a/src/Playlist.cxx
+++ b/src/Playlist.cxx
@@ -48,6 +48,7 @@ playlist::TagModified(Song &&song)
 		current_song.ReplaceTag(std::move(*song.tag));

 	queue.ModifyAtOrder(current);
+	queue.IncrementVersion();
 	idle_add(IDLE_PLAYLIST);
 }


--- a/src/Queue.cxx
+++ b/src/Queue.cxx
@@ -83,8 +83,6 @@ queue::ModifyAtOrder(unsigned _order)

 	unsigned position = order[_order];
 	items[position].version = version;
-
-	IncrementVersion();
 }

 void

--- a/src/Queue.hxx
+++ b/src/Queue.hxx
@@ -241,7 +241,8 @@ struct queue {
 	void IncrementVersion();

 	/**
-	 * Marks the specified song as "modified" and increments the version
+	 * Marks the specified song as "modified".  Call
+	 * IncrementVersion() after all modifications have been made.
 	 * number.
 	 */
 	void ModifyAtOrder(unsigned order);