PcmBuffer: reset size in Clear()

Fix for Mantis #3806. "PcmBuffer::Clear clears the buffer but does not reset the size. If Get is called on the same PcmBuffer later on with a size that is the same as (or less than) it was before the call to Clear, the "else" branch is taken and the memory of buffer (at the address of nullptr) is poisoned instead of the necessary allocation being performed. A memset or memcpy on the returned pointer (nullptr) causes a segmentation fault."

PcmBuffer: reset size in Clear()
105b431e · Max Kellermann · ba79f4c1 · 105b431e
Commit 105b431e authored Aug 01, 2013 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

PcmBuffer.hxx src/pcm/PcmBuffer.hxx +1 -0

No files found.
--- a/src/pcm/PcmBuffer.hxx
+++ b/src/pcm/PcmBuffer.hxx
@@ -46,6 +46,7 @@ struct PcmBuffer {
 	void Clear() {
 		g_free(buffer);
 		buffer = nullptr;
+		size = 0;
 	}

 	/**