Revert "systemd: add "RuntimeDirectory" directive"

This reverts commit 552c30ea. It has caused various problems; for example, MPD wasn't able to write the pid_file (which was already mitigated by commit a4e42172). And apparently, the socket file created in the same directory by mpd.socket disappears when mpd.service (re)creates the directory. I could not reproduce this problem with 247.3, but maybe this is a bug in older systemd versions? Until we figure out why this happens, let's remove the RuntimeDirectory directive. A future MPD version may be launched as regular user, not as root, which will eliminate one major problem with RuntimeDirectory.

Revert "systemd: add "RuntimeDirectory" directive"
1112d390 · Max Kellermann · 34644978 · 1112d390 · 1112d390 · 1112d390
Commit 1112d390 authored Nov 11, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 9 deletions

NEWS NEWS +3 -1

mpd.service.in systemd/system/mpd.service.in +0 -4

mpd.service.in systemd/user/mpd.service.in +0 -4

No files found.
--- a/NEWS
+++ b/NEWS
@@ -6,7 +6,9 @@ ver 0.23.4 (not yet released)
 * output
  - alsa: add option "thesycon_dsd_workaround" to work around device bug
 * fix crash on debug builds if startup fails
-* ignore the "pid_file" setting if started as systemd service
+* systemd
+  - remove "RuntimeDirectory" directive because it caused problems
+  - ignore the "pid_file" setting if started as systemd service
 * Windows
  - enable the "openmpt" decoder plugin

--- a/systemd/system/mpd.service.in
+++ b/systemd/system/mpd.service.in
@@ -7,10 +7,6 @@ After=network.target sound.target
 Type=notify
 ExecStart=@prefix@/bin/mpd --systemd
-# Create /run/mpd (if MPD is launched without the socket unit and is
-# configured to bind listener sockets there).
-RuntimeDirectory=mpd
 # Enable this setting to ask systemd to watch over MPD, see
 # systemd.service(5).  This is disabled by default because it causes
 # periodic wakeups which are unnecessary if MPD is not playing.

--- a/systemd/user/mpd.service.in
+++ b/systemd/user/mpd.service.in
@@ -7,10 +7,6 @@ After=network.target sound.target
 Type=notify
 ExecStart=@prefix@/bin/mpd --systemd
-# Create /run/user/$UID/mpd (if MPD is launched without the socket
-# unit and is configured to bind listener sockets there).
-RuntimeDirectory=mpd
 # Enable this setting to ask systemd to watch over MPD, see
 # systemd.service(5).  This is disabled by default because it causes
 # periodic wakeups which are unnecessary if MPD is not playing.