client_file: remove pure attribute from client_allow_file().

That function is not pure, it writes to error. When marked as pure, the compiler is allowed to assume it does not do anything to error, so it can remain NULL, which would result in an invalid read in print_error().

client_file: remove pure attribute from client_allow_file().
12be9e81 · Anton Khirnov · Max Kellermann · 281cd7c0 · 12be9e81 · 12be9e81
Commit 12be9e81 authored Aug 12, 2012 by Anton Khirnov Committed by Max Kellermann Aug 13, 2012
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +2 -0

client_file.h src/client_file.h +0 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.17.2 (2012/??/??)
+* protocol:
+  - fix crash in local file check


 ver 0.17.1 (2012/07/31)

--- a/src/client_file.h
+++ b/src/client_file.h
@@ -35,7 +35,6 @@ struct client;
 * @param path_fs the absolute path name in filesystem encoding
 * @return true if access is allowed
 */
-G_GNUC_PURE
 bool
 client_allow_file(const struct client *client, const char *path_fs,
 		  GError **error_r);