player: don't wake up decoder after every frame

The decoder was woken up after each chunk which had been played. That caused a lot of superfluous context switches. Wake up the decoder only when a certain amount of the buffer has been consumed. This formula is somewhat arbitrary, and has to be proven experimentally.

player: don't wake up decoder after every frame
17d9c170 · Max Kellermann · f41fe1e0 · 17d9c170
Commit 17d9c170 authored Oct 10, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 1 deletion

player_thread.c src/player_thread.c +7 -1

No files found.
--- a/src/player_thread.c
+++ b/src/player_thread.c
@@ -339,7 +339,13 @@ static void do_play(void)
 				      sizeToTime) < 0)
 				break;
 			ob_shift();
-			notify_signal(&dc.notify);
+
+			/* this formula should prevent that the
+			   decoder gets woken up with each chunk; it
+			   is more efficient to make it decode a
+			   larger block at a time */
+			if (ob_available() <= (pc.buffered_before_play + ob.size * 3) / 4)
+				notify_signal(&dc.notify);
 		} else if (!ob_is_empty() && (int)ob.begin == next) {
 			/* at the beginning of a new song */