listen: allocate sockaddr_storage struct for accept()

The generic sockaddr struct is too small for some addresses. For accept(), we have to allocate a sockaddr_storage struct on the stack, which is large enough for all addresses.

listen: allocate sockaddr_storage struct for accept()
1bb0124b · Max Kellermann · 5c10d2de · 1bb0124b · 1bb0124b
Commit 1bb0124b authored Feb 28, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 4 deletions

NEWS NEWS +1 -0

listen.c src/listen.c +5 -4

No files found.
--- a/NEWS
+++ b/NEWS
@@ -41,6 +41,7 @@ ver 0.15 - (200?/??/??)
 * playlist: recalculate the queued song after random is toggled
 * playlist: don't unpause on delete
 * daemon: ignore "user" setting if already running as that user
+* listen: fix broken client IP addresses in log
 ver 0.14.2 (2009/02/13)

--- a/src/listen.c
+++ b/src/listen.c
@@ -448,14 +448,15 @@ listen_in_event(G_GNUC_UNUSED GIOChannel *source,
 		gpointer data)
 {
 	int listen_fd = GPOINTER_TO_INT(data), fd;
-	struct sockaddr sockAddr;
+	struct sockaddr_storage sa;
-	socklen_t socklen = sizeof(sockAddr);
+	socklen_t sa_length = sizeof(sa);
-	fd = accept(listen_fd, &sockAddr, &socklen);
+	fd = accept(listen_fd, (struct sockaddr*)&sa, &sa_length);
 	if (fd >= 0) {
 		set_nonblocking(fd);
-		client_new(fd, &sockAddr, socklen, get_remote_uid(fd));
+		client_new(fd, (struct sockaddr*)&sa, sa_length,
+			   get_remote_uid(fd));
 	} else if (fd < 0 && errno != EINTR) {
 		g_warning("Problems accept()'ing");
 	}