client: client_input_received() returns 0

Since the caller chain doesn't care about the return value (except for COMMAND_RETURN_KILL, COMMAND_RETURN_CLOSE), just return 0 if there is nothing special. This saves one local variable initialization, and one access to it. Also remove one unreachable "return 1" from client_read().

client: client_input_received() returns 0
1bb15409 · Max Kellermann · 48191d56 · 1bb15409
Commit 1bb15409 authored Sep 10, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

client.c src/client.c +2 -4

No files found.
--- a/src/client.c
+++ b/src/client.c
@@ -400,7 +400,7 @@ static int client_process_line(struct client *client)

 static int client_input_received(struct client *client, int bytesRead)
 {
-	int ret = 0;
+	int ret;
 	char *buf_tail = &(client->buffer[client->bufferLength - 1]);

 	while (bytesRead > 0) {
@@ -440,7 +440,7 @@ static int client_input_received(struct client *client, int bytesRead)
 		}
 	}

-	return ret;
+	return 0;
 }

 static int client_read(struct client *client)
@@ -457,8 +457,6 @@ static int client_read(struct client *client)
 		return COMMAND_RETURN_CLOSE;
 	} else
 		return 0;
-
-	return 1;
 }

 static void client_manager_register_read_fd(fd_set * fds, int *fdmax)