input/AsyncInputStream: set Error when seeking unseekable

Fixes crash in the "audiofile" decoder while logging the seek error.

input/AsyncInputStream: set Error when seeking unseekable
1bd8a322 · Max Kellermann · 362e73be · 1bd8a322 · 1bd8a322
Commit 1bd8a322 authored Nov 07, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

NEWS NEWS +2 -0

AsyncInputStream.cxx src/input/AsyncInputStream.cxx +4 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.19.3 (not yet released)
+* decoder
+  - audiofile: fix crash while playing streams

 ver 0.19.2 (2014/11/02)
 * input

--- a/src/input/AsyncInputStream.cxx
+++ b/src/input/AsyncInputStream.cxx
@@ -19,6 +19,7 @@

 #include "config.h"
 #include "AsyncInputStream.hxx"
+#include "Domain.hxx"
 #include "tag/Tag.hxx"
 #include "event/Call.hxx"
 #include "thread/Cond.hxx"
@@ -113,8 +114,10 @@ AsyncInputStream::Seek(offset_type new_offset, Error &error)
 		/* no-op */
 		return true;

-	if (!IsSeekable())
+	if (!IsSeekable()) {
+		error.Set(input_domain, "Not seekable");
 		return false;
+	}

 	/* check if we can fast-forward the buffer */