input/curl: use class MaybeBufferedInputStream

For remote files (not streams), this downloads as quickly as possible to a large buffer instead of throttling the stream during playback. Throttling can make the server impatient and it may then disconnect. This is what Qobuz and Tidal do, and this commit attempts to solve this by not letting the Qobuz/Tidal server wait (closes #241).

input/curl: use class MaybeBufferedInputStream
1ca1269a · Max Kellermann · 6681b14b · 1ca1269a · 1ca1269a
Commit 1ca1269a authored Jun 14, 2018 by Max Kellermann
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +1 -0

CurlInputPlugin.cxx src/input/plugins/CurlInputPlugin.cxx +2 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -8,6 +8,7 @@ ver 0.21 (not yet released)
 * player
  - "one-shot" single mode
 * input
+  - curl: download to buffer instead of throttling transfer
  - qobuz: new plugin to play Qobuz streams
  - tidal: new plugin to play Tidal streams
 * tags

--- a/src/input/plugins/CurlInputPlugin.cxx
+++ b/src/input/plugins/CurlInputPlugin.cxx
@@ -25,6 +25,7 @@
 #include "lib/curl/Request.hxx"
 #include "lib/curl/Handler.hxx"
 #include "lib/curl/Slist.hxx"
+#include "../MaybeBufferedInputStream.hxx"
 #include "../AsyncInputStream.hxx"
 #include "../IcyInputStream.hxx"
 #include "IcyMetaDataParser.hxx"
@@ -458,7 +459,7 @@ CurlInputStream::Open(const char *url,
 			c->StartRequest();
 		});

-	return std::make_unique<IcyInputStream>(std::move(c), std::move(icy));
+	return std::make_unique<MaybeBufferedInputStream>(std::make_unique<IcyInputStream>(std::move(c), std::move(icy)));
 }

 InputStreamPtr