output/shout: remove the defunct "timeout" option

doc/plugins.rst

@@ -1143,8 +1143,6 @@ You must set a format.
      - Sets the host name of the `ShoutCast <http://www.shoutcast.com/>`_ / `IceCast <http://icecast.org/>`_ server.
    * - **port PORTNUMBER**
      - Connect to this port number on the specified host.
-   * - **timeout SECONDS**
-     - Set the timeout for the shout connection in seconds. Defaults to 2 seconds.
    * - **protocol icecast2|icecast1|shoutcast**
      - Specifies the protocol that wil be used to connect to the server. The default is "icecast2".
    * - **tls disabled|auto|auto_no_plain|rfc2818|rfc2817**

src/output/plugins/ShoutOutputPlugin.cxx

@@ -36,16 +36,12 @@
 
 #include <stdio.h>
 
-static constexpr unsigned DEFAULT_CONN_TIMEOUT = 2;
-
 struct ShoutOutput final : AudioOutput {
 	shout_t *shout_conn;
 
 	std::unique_ptr<PreparedEncoder> prepared_encoder;
 	Encoder *encoder;
 
-	int timeout = DEFAULT_CONN_TIMEOUT;
-
 	uint8_t buffer[32768];
 
 	explicit ShoutOutput(const ConfigBlock &block);
@@ -180,7 +176,6 @@ ShoutOutput::ShoutOutput(const ConfigBlock &block)
 		throw std::runtime_error(shout_get_error(shout_conn));
 
 	/* optional paramters */
-	timeout = block.GetBlockValue("timeout", DEFAULT_CONN_TIMEOUT);
 
 	value = block.GetBlockValue("genre");
 	if (value != nullptr && shout_set_genre(shout_conn, value))