input/curl: remove assertion after curl_multi_fdset()

Some users reported that MPD crashes when using a new CURL version with the threaded DNS resolver enabled. It seems that curl_multi_fdset() returns no file descriptor when the DNS resolver runs in another thread, so MPD does not have any event to wait for. On the CURL mailing list, somebody suggested to sleep for a fixed amount of time. This is not an elegant solution, because daemons should never have to sleep without waiting for an event. I hope the CURL developers will review the API and remove the threaded DNS resolver. Meanwhile, I'm removing the assertion in question, to allow those unfortunate users running the latest CURL version to continue using MPD.

input/curl: remove assertion after curl_multi_fdset()
1f976d6e · Max Kellermann · a4908dca · 1f976d6e · 1f976d6e
Commit 1f976d6e authored Jul 20, 2010 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

NEWS NEWS +2 -0

curl_input_plugin.c src/input/curl_input_plugin.c +0 -2

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.15.12 (2010/??/??)
+* input:
+  - curl: remove assertion after curl_multi_fdset()
 * tags:
  - rva2: set "gain", not "peak"
 * decoders:

--- a/src/input/curl_input_plugin.c
+++ b/src/input/curl_input_plugin.c
@@ -259,8 +259,6 @@ input_curl_select(struct input_curl *c)
 		return -1;
 	}

-	assert(max_fd >= 0);
-
 #if LIBCURL_VERSION_NUM >= 0x070f00
 	long timeout2;
 	mcode = curl_multi_timeout(c->multi, &timeout2);