java/Ref: add nullptr check to destructor

May allow the compiler to optimize calls away.

java/Ref: add nullptr check to destructor
296ec4d0 · Max Kellermann · Max Kellermann · 6e58fd15 · 296ec4d0
Commit 296ec4d0 authored Mar 28, 2021 by Max Kellermann Committed by Max Kellermann Apr 06, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

Ref.hxx src/java/Ref.hxx +2 -1

No files found.
--- a/src/java/Ref.hxx
+++ b/src/java/Ref.hxx
@@ -62,7 +62,8 @@ namespace Java {
 			 value(std::exchange(src.value, nullptr)) {}

 		~LocalRef() noexcept {
-			env->DeleteLocalRef(value);
+			if (value != nullptr)
+				env->DeleteLocalRef(value);
 		}

 		LocalRef(const LocalRef &other) = delete;