db/upnp: Namei() returns error when no object was found

Don't fail silently.

db/upnp: Namei() returns error when no object was found
2cb912e4 · Max Kellermann · 91a513e8 · 2cb912e4
Commit 2cb912e4 authored Jan 14, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

UpnpDatabasePlugin.cxx src/db/UpnpDatabasePlugin.cxx +5 -2

No files found.
--- a/src/db/UpnpDatabasePlugin.cxx
+++ b/src/db/UpnpDatabasePlugin.cxx
@@ -575,7 +575,9 @@ UpnpDatabase::Namei(ContentDirectoryService* server,
 					odirent = dirent;
 					return true;
 				} else {
-					return true;
+					error.Format(db_domain, DB_NOT_FOUND,
+						     "No such object");
+					return false;
 				}
 			}
 		}
@@ -585,7 +587,8 @@ UpnpDatabase::Namei(ContentDirectoryService* server,
 			break;
 	}

-	return true;
+	error.Format(db_domain, DB_NOT_FOUND, "No such object");
+	return false;
 }

 // vpath is a parsed and writeable version of selection.uri. There is