player/Thread: remove `buffered_before_play` from `decoder_wakeup_threshold` formula

Simplify the formula, and I guess this makes the formula more reliable. Imagine somebody configured `buffered_before_play` larger than 25%; then the decoder would be woken up all the time. This doesn't seem logical. On the other hand, it's easy to understand that the decoder should be woken up below 75% buffer fill.

player/Thread: remove `buffered_before_play` from `decoder_wakeup_threshold` formula
2f3845ef · Max Kellermann · 1191025b · 2f3845ef
Commit 2f3845ef authored Sep 23, 2018 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 2 deletions

Thread.cxx src/player/Thread.cxx +1 -2

No files found.
--- a/src/player/Thread.cxx
+++ b/src/player/Thread.cxx
@@ -185,8 +185,7 @@ public:
 	Player(PlayerControl &_pc, DecoderControl &_dc,
 	       MusicBuffer &_buffer) noexcept
 		:pc(_pc), dc(_dc), buffer(_buffer),
-		 decoder_wakeup_threshold((pc.buffered_before_play +
-					   buffer.GetSize() * 3) / 4)
+		 decoder_wakeup_threshold(buffer.GetSize() * 3 / 4)
 	{
 	}