archive/iso9660: fix off-by-one assertion failure

Calling data[fill] could trigger an assertion failure if fill==data.size(), even if we call it only to take the address. Instead of doing that, this commit changes the code to pointer arithmetic. Closes https://github.com/MusicPlayerDaemon/MPD/issues/1556

archive/iso9660: fix off-by-one assertion failure
3b05c897 · Max Kellermann · e77b3fa4 · 3b05c897
Commit 3b05c897 authored Sep 06, 2022 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

Iso9660ArchivePlugin.cxx src/archive/plugins/Iso9660ArchivePlugin.cxx +1 -1

No files found.
--- a/src/archive/plugins/Iso9660ArchivePlugin.cxx
+++ b/src/archive/plugins/Iso9660ArchivePlugin.cxx
@@ -166,7 +166,7 @@ class Iso9660InputStream final : public InputStream {
 			assert(fill <= data.size());
 			assert(position <= fill);

-			return {&data[position], &data[fill]};
+			return {data.data() + position, data.data() + fill};
 		}

 		void Consume(size_t nbytes) noexcept {