storage/curl: fix href when file has a '&' char

If the file name is "Hello & bye", 3 CharacterData events will be sent with the State::HREF state: - "Hello%20" - "&" - "%20bye" Reproduced with files hosted on an apache2 DAV server: 2.4.38-3+deb10u3.

storage/curl: fix href when file has a '&' char
3d8067a0 · Thomas Guillem · Max Kellermann · f6fe001f · 3d8067a0 · 3d8067a0
Commit 3d8067a0 authored Apr 13, 2020 by Thomas Guillem Committed by Max Kellermann Apr 15, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +2 -0

CurlStorage.cxx src/storage/plugins/CurlStorage.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.21.23 (not yet released)
+* storage
+  - curl: fix corrupt "href" values in the presence of XML entities
 * output
  - alsa: implement channel mapping for 5.0 and 7.0
 * player

--- a/src/storage/plugins/CurlStorage.cxx
+++ b/src/storage/plugins/CurlStorage.cxx
@@ -402,7 +402,7 @@ private:
 			break;

 		case State::HREF:
-			response.href.assign(s, len);
+			response.href.append(s, len);
 			break;

 		case State::STATUS: