0.11.4

ChangeLog

+ver 0.11.4 (2004/7/26)
+1) Fixed a segfault when decoding mp3's with corrupt id3v2 tags
+2) Fixed a memory leak when encountering id3v2 tags in mp3 decoder
+
 ver 0.11.3 (2004/7/21)
 1) Add support for http authentication for streams
 2) Added replaygain pre-amp support

TODO

 0.12
 ----
+*) Rewrite replaygain stuff:
+	*) Replay gain struct with album and track gain's and peak's
+	*) Pass these to replaygain function
+	*) Don't have deocder plugins inquire weather or not to use replaygain,
+		they should just parse tags and pass these to replaygain func
+	*) If replaygain tag info present, average the replaygain gain's
+		and peak's on the fly
+	*) If NULL replaygain struct, then use the average replaygain gains
+		and peak's to compute the the scale for files missing
+		replaygain tags (make this a config file option)
+
 *) Optimize read() on cleints
 
 *) Add libshout && vorbis encoding support
 
-*) add command that only takes file's or url's (no directory's) and returns the songid of the added song
-
-*) allow add commands to specify position to be inserted
+*) add command
+	*) command that takes file/url's (no directory's) and returns the songid
+	*) allow to specify position in playlist where to insert song(s)
 
-*) saved playlist commands for getting the contents of a playlist and appending to a playlist
+*) rewrite saved playlist code
+	*) abstract out saved playlists from playlist.c
+	*) command for displaying playlist contents
+	*) command for appending to playlist
 
 *) have listallinfo return directories
 

configure

 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.59 for mpd 0.11.3.
+# Generated by GNU Autoconf 2.59 for mpd 0.11.4.
 #
 # Report bugs to <shank@mercury.chem.pitt.edu>.
 #
@@ -423,8 +423,8 @@ SHELL=${CONFIG_SHELL-/bin/sh}
 # Identity of this package.
 PACKAGE_NAME='mpd'
 PACKAGE_TARNAME='mpd'
-PACKAGE_VERSION='0.11.3'
-PACKAGE_STRING='mpd 0.11.3'
+PACKAGE_VERSION='0.11.4'
+PACKAGE_STRING='mpd 0.11.4'
 PACKAGE_BUGREPORT='shank@mercury.chem.pitt.edu'
 
 # Factoring default headers for most tests.
@@ -955,7 +955,7 @@ if test "$ac_init_help" = "long"; then
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures mpd 0.11.3 to adapt to many kinds of systems.
+\`configure' configures mpd 0.11.4 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1021,7 +1021,7 @@ fi
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of mpd 0.11.3:";;
+     short | recursive ) echo "Configuration of mpd 0.11.4:";;
    esac
   cat <<\_ACEOF
 
@@ -1207,7 +1207,7 @@ fi
 test -n "$ac_init_help" && exit 0
 if $ac_init_version; then
   cat <<\_ACEOF
-mpd configure 0.11.3
+mpd configure 0.11.4
 generated by GNU Autoconf 2.59
 
 Copyright (C) 2003 Free Software Foundation, Inc.
@@ -1221,7 +1221,7 @@ cat >&5 <<_ACEOF
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by mpd $as_me 0.11.3, which was
+It was created by mpd $as_me 0.11.4, which was
 generated by GNU Autoconf 2.59.  Invocation command line was
 
   $ $0 $@
@@ -26085,7 +26085,7 @@ _ASBOX
 } >&5
 cat >&5 <<_CSEOF
 
-This file was extended by mpd $as_me 0.11.3, which was
+This file was extended by mpd $as_me 0.11.4, which was
 generated by GNU Autoconf 2.59.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -26148,7 +26148,7 @@ _ACEOF
 
 cat >>$CONFIG_STATUS <<_ACEOF
 ac_cs_version="\\
-mpd config.status 0.11.3
+mpd config.status 0.11.4
 configured by $0, generated by GNU Autoconf 2.59,
   with options \\"`echo "$ac_configure_args" | sed 's/[\\""\`\$]/\\\\&/g'`\\"
 

configure.ac

@@ -2,7 +2,7 @@ dnl AC_INIT(src/main.c)
 dnl AM_INIT_AUTOMAKE(mpd, 0.10.0)
 
 AC_PREREQ(2.52)
-AC_INIT(mpd, 0.11.3, shank@mercury.chem.pitt.edu)
+AC_INIT(mpd, 0.11.4, shank@mercury.chem.pitt.edu)
 AM_INIT_AUTOMAKE($PACKAGE_NAME, $PACKAGE_VERSION)
 
 dnl MAD wants this stuff

doc/mpd.1

@@ -133,6 +133,9 @@ This specifies the format all decoded audio should be converted to for playing.
 .B replaygain <album or track>
 This specifies whether to use replaygain tags (currently only supported for FLAC and Ogg Vorbis formats).
 .TP
+.B replaygain_preamp <-15 to 15>
+This is the gain (in dB) applied to songs with replaygain tags.
+.TP
 .B max_command_list_size <size in KB>
 This specifies the maximum size a command list can be (in kilobytes). The default is 2048 kilobytes.
 .TP
@@ -253,6 +256,8 @@ bind_to_address         "any"
 .br
 #replaygain		"album"
 .br
+#replaygain_preamp	"0"
+.br
 #http_proxy_host	"proxy.isp.com"
 .br
 #http_proxy_port	"8080"

src/inputPlugins/mp3_plugin.c

@@ -246,7 +246,10 @@ static MpdTag * mp3_parseId3Tag(mp3DecodeData * data, signed long tagsize) {
 
 	id3Tag = id3_tag_parse(id3_data, tagsize);
  
-	ret = parseId3Tag(id3Tag);
+	if(id3Tag) {
+		ret = parseId3Tag(id3Tag);
+		id3_tag_delete(id3Tag);
+	}
 
 fail:
 	if(allocated) free(allocated);
@@ -272,7 +275,8 @@ int decodeNextFrameHeader(mp3DecodeData * data, MpdTag ** tag) {
 
 			if(tagsize>0) {
 				if(tag && !(*tag)) {
-					*tag =mp3_parseId3Tag(data, tagsize);
+					*tag = mp3_parseId3Tag(data, tagsize);
+					
 				}
 				else {
 					mad_stream_skip(&(data->stream),