pcm: fixed software volume, broken by unsigned integer

"volume" was passed as an unsigned integer, which is correct. It's just that when it was multiplied with the sample value, the whole operation was changed to unsigned, breaking the algorithm (and Qball's ears). Internally change "volume" to signed.

pcm: fixed software volume, broken by unsigned integer
40f59cac · Max Kellermann · ecc3c39e · 40f59cac
Commit 40f59cac authored Oct 09, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 6 deletions

pcm_utils.c src/pcm_utils.c +3 -6

No files found.
--- a/src/pcm_utils.c
+++ b/src/pcm_utils.c
@@ -47,8 +47,7 @@ pcm_range(int32_t sample, unsigned bits)
 }

 static void
-pcm_volume_change_8(int8_t *buffer, unsigned num_samples,
-		    unsigned volume)
+pcm_volume_change_8(int8_t *buffer, unsigned num_samples, int volume)
 {
 	while (num_samples > 0) {
 		int32_t sample = *buffer;
@@ -61,8 +60,7 @@ pcm_volume_change_8(int8_t *buffer, unsigned num_samples,
 }

 static void
-pcm_volume_change_16(int16_t *buffer, unsigned num_samples,
-		     unsigned volume)
+pcm_volume_change_16(int16_t *buffer, unsigned num_samples, int volume)
 {
 	while (num_samples > 0) {
 		int32_t sample = *buffer;
@@ -75,8 +73,7 @@ pcm_volume_change_16(int16_t *buffer, unsigned num_samples,
 }

 static void
-pcm_volume_change_24(int32_t *buffer, unsigned num_samples,
-		     unsigned volume)
+pcm_volume_change_24(int32_t *buffer, unsigned num_samples, int volume)
 {
 	while (num_samples > 0) {
 		int64_t sample = *buffer;