zeroconf/Bonjour: don't call DNSServiceRefDeallocate() if DNSServiceRegister() fails

According to https://developer.apple.com/documentation/dnssd/1804733-dnsserviceregister the DNSServiceRef is initialized only if DNSServiceRegister() returns kDNSServiceErr_NoError. The faulty error handling code could therefore crash.

zeroconf/Bonjour: don't call DNSServiceRefDeallocate() if DNSServiceRegister() fails
47461df5 · Max Kellermann · 04d5588f · 47461df5
Commit 47461df5 authored Feb 24, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 5 deletions

Bonjour.cxx src/zeroconf/Bonjour.cxx +0 -5

No files found.
--- a/src/zeroconf/Bonjour.cxx
+++ b/src/zeroconf/Bonjour.cxx
@@ -97,11 +97,6 @@ BonjourInit(EventLoop &loop, const char *service_name, unsigned port)
 	if (error != kDNSServiceErr_NoError) {
 		LogError(bonjour_domain,
 			 "Failed to register zeroconf service");
-
-		if (dnsReference) {
-			DNSServiceRefDeallocate(dnsReference);
-			dnsReference = nullptr;
-		}
 		return;
 	}