db/simple/ExportedSong: check src.OwnsTag(), not this->OwnsTag()

this->OwnsTag() accesses fields that are not yet initialized.

db/simple/ExportedSong: check src.OwnsTag(), not this->OwnsTag()
5355335f · Max Kellermann · 64fa76c5 · 5355335f · 5355335f
Commit 5355335f authored Jul 30, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +2 -0

ExportedSong.hxx src/db/plugins/simple/ExportedSong.hxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.22.10 (not yet released)
 * protocol
  - support "albumart" for virtual tracks in CUE sheets
+* database
+  - simple: fix crash bug

 ver 0.22.9 (2021/06/23)
 * database

--- a/src/db/plugins/simple/ExportedSong.hxx
+++ b/src/db/plugins/simple/ExportedSong.hxx
@@ -53,7 +53,7 @@ public:
 			      moved-from instance also owned the Tag
 			      which its LightSong::tag field refers
 			      to */
-			   OwnsTag() ? tag_buffer : src.tag),
+			   src.OwnsTag() ? tag_buffer : src.tag),
 		 tag_buffer(std::move(src.tag_buffer)) {}

 	ExportedSong &operator=(ExportedSong &&) = delete;