Commit 56c0733b authored by Max Kellermann's avatar Max Kellermann

meson.build: disable -Wsuggest-override with GCC 8

parent 0b0acb39
...@@ -72,7 +72,6 @@ test_cxxflags = test_common_flags + [ ...@@ -72,7 +72,6 @@ test_cxxflags = test_common_flags + [
'-Woverloaded-virtual', '-Woverloaded-virtual',
'-Wshadow', '-Wshadow',
'-Wsign-promo', '-Wsign-promo',
'-Wsuggest-override',
'-Wunused', '-Wunused',
'-Wvolatile', '-Wvolatile',
'-Wvirtual-inheritance', '-Wvirtual-inheritance',
...@@ -89,6 +88,12 @@ test_cxxflags = test_common_flags + [ ...@@ -89,6 +88,12 @@ test_cxxflags = test_common_flags + [
'-Wused-but-marked-unused', '-Wused-but-marked-unused',
] ]
if compiler.get_id() != 'gcc' or compiler.version().version_compare('>=9')
# The GCC 8 implementation of this flag is buggy: it complains even
# if "final" is present, which implies "override".
test_cxxflags += '-Wsuggest-override'
endif
test_cflags = test_common_flags + [ test_cflags = test_common_flags + [
'-Wcast-qual', '-Wcast-qual',
'-Wmissing-prototypes', '-Wmissing-prototypes',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment