player/Thread: cancel outputs before seeking

.. instead of doing it after seeking. After seeking, the command had no effect, because CheckDecoderStartup() waits for all outputs to finish. This caused a very long delay while seeking and switching songs (https://bugs.musicpd.org/view.php?id=4534).

player/Thread: cancel outputs before seeking
5771d672 · Max Kellermann · 75c8aecf · 5771d672 · 5771d672
Commit 5771d672 authored Jun 13, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

NEWS NEWS +1 -0

PlayerThread.cxx src/PlayerThread.cxx +2 -2

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.19.16 (not yet released)
+* faster seeking
 * fix system include path order
 * add missing DocBook file to tarball


--- a/src/PlayerThread.cxx
+++ b/src/PlayerThread.cxx
@@ -518,6 +518,8 @@ Player::SeekDecoder()
 {
 	assert(pc.next_song != nullptr);

+	pc.outputs.Cancel();
+
 	const SongTime start_time = pc.next_song->GetStartTime();

 	if (!dc.LockIsCurrentSong(*pc.next_song)) {
@@ -583,8 +585,6 @@ Player::SeekDecoder()
 	/* re-fill the buffer after seeking */
 	buffering = true;

-	pc.outputs.Cancel();
-
 	return true;
 }