output/httpd: fix nullptr dereference crash bug

When `metadata_sent` is `false`, the plugin assumes there is metadata which must be sent, even if no metadata page was passed to the plugin. Initializing it to `true` avoids dereferencing this `nullptr`. Fixes #412

output/httpd: fix nullptr dereference crash bug
583208db · Max Kellermann · 7b5ba151 · 583208db · 583208db
Commit 583208db authored Nov 08, 2018 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

NEWS NEWS +1 -1

HttpdClient.hxx src/output/plugins/httpd/HttpdClient.hxx +4 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,7 +3,7 @@ ver 0.21.2 (not yet released)
  - ffmpeg: require FFmpeg 3.1 or later
  - ffmpeg: fix broken sound with certain codecs
 * output
-  - httpd: fix crash with "always_on"
+  - httpd: fix two crash bugs
 * fix zlib support

 ver 0.21.1 (2018/11/04)

--- a/src/output/plugins/httpd/HttpdClient.hxx
+++ b/src/output/plugins/httpd/HttpdClient.hxx
@@ -98,8 +98,11 @@ class HttpdClient final

 	/**
 	 * If the current metadata was already sent to the client.
+	 *
+	 * Initialized to `true` because there is no metadata #Page
+	 * pending to be sent.
 	 */
-	bool metadata_sent = false;
+	bool metadata_sent = true;

 	/**
 	 * The amount of streaming data between each metadata block