command/database: fix "list" with filter expression

Disable the 0.11 compatibility mode if the only argument is a filter expression. Closes https://github.com/MusicPlayerDaemon/MPD/issues/506

command/database: fix "list" with filter expression
59fdfd25 · Max Kellermann · 0d986772 · 59fdfd25 · 59fdfd25
Commit 59fdfd25 authored Mar 14, 2019 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

NEWS NEWS +1 -0

DatabaseCommands.cxx src/command/DatabaseCommands.cxx +4 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.21.6 (not yet released)
 * protocol
  - allow loading playlists specified as absolute filesystem paths
+  - fix "list" with filter expression
 * input
  - cdio_paranoia: fix build failure due to missing #include
 * playlist

--- a/src/command/DatabaseCommands.cxx
+++ b/src/command/DatabaseCommands.cxx
@@ -268,7 +268,10 @@ handle_list(Client &client, Request args, Response &r)
 	std::unique_ptr<SongFilter> filter;
 	TagType group = TAG_NUM_OF_ITEM_TYPES;

-	if (args.size == 1) {
+	if (args.size == 1 &&
+	    /* parantheses are the syntax for filter expressions: no
+	       compatibility mode */
+	    args.front()[0] != '(') {
 		/* for compatibility with < 0.12.0 */
 		if (tagType != TAG_ALBUM) {
 			r.FormatError(ACK_ERROR_ARG,