pcm_utils: always round up resampling buffer size

libsamplerate produces cracks in the sound output when the destination buffer is too small. This is the case when pcm_convert_size() rounds down. Use ceil(x) instead of floor(0.5+x) there to prevent a buffer overrun.

pcm_utils: always round up resampling buffer size
5b11d5a3 · Max Kellermann · 0128a9e9 · 5b11d5a3
Commit 5b11d5a3 authored Dec 08, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 1 deletion

pcm_utils.c src/pcm_utils.c +1 -1

No files found.
--- a/src/pcm_utils.c
+++ b/src/pcm_utils.c
@@ -461,7 +461,7 @@ size_t pcm_convert_size(const struct audio_format *inFormat, size_t src_size,
 	assert((src_size % audio_format_frame_size(inFormat)) == 0);
 	dest_size /= audio_format_frame_size(inFormat);
-	dest_size = floor(0.5 + (double)dest_size * ratio);
+	dest_size = ceil((double)dest_size * ratio);
 	dest_size *= audio_format_frame_size(outFormat);
 	return dest_size;