stored_playlist: don't close NULL file on error

spl_append_song() can crash when fopen() fails, because it attempts to close the invalid file handle (NULL) in the error handler.

stored_playlist: don't close NULL file on error
5ce625ea · Max Kellermann · 85658965 · 5ce625ea
Commit 5ce625ea authored Apr 24, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 5 deletions

stored_playlist.c src/stored_playlist.c +1 -5

No files found.
--- a/src/stored_playlist.c
+++ b/src/stored_playlist.c
@@ -379,12 +379,8 @@ spl_append_song(const char *utf8path, struct song *song)

 	while (!(file = fopen(path_fs, "a")) && errno == EINTR);
 	g_free(path_fs);
-	if (file == NULL) {
-		int save_errno = errno;
-		while (fclose(file) != 0 && errno == EINTR);
-		errno = save_errno;
+	if (file == NULL)
 		return PLAYLIST_RESULT_ERRNO;
-	}

 	if (fstat(fileno(file), &st) < 0) {
 		int save_errno = errno;