input/lastfm: Ensure multiple identical xml entities are decoded.

Previously, if two identical entities appeared in one string, only the first would get decoded. This fixes that bug.

input/lastfm: Ensure multiple identical xml entities are decoded.
614a0118 · Courtney Cavin · 0c66832b · 614a0118
Commit 614a0118 authored Jul 28, 2009 by Courtney Cavin
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 6 deletions

lastfm_input_plugin.c src/input/lastfm_input_plugin.c +5 -6

No files found.
--- a/src/input/lastfm_input_plugin.c
+++ b/src/input/lastfm_input_plugin.c
@@ -175,13 +175,12 @@ lastfm_xmldecode(const char *value)
 	unsigned int i;
 	for (i = 0; i < sizeof(entities)/sizeof(entities[0]); ++i) {
+		char *p;
 		int slen = strlen(entities[i].text);
-		char *p = strstr(txt, entities[i].text);
+		while ((p = strstr(txt, entities[i].text))) {
-		if (p == NULL)
+			*p = entities[i].repl;
-			continue;
+			g_strlcpy(p + 1, p + slen, strlen(p) - slen);
+		}
-		*p = entities[i].repl;
-		g_strlcpy(p + 1, p + slen, strlen(p) - slen);
 	}
 	return txt;
 }