decoder/faad: check sample_rate, not frames_per_second

Checking the integer is faster, easier and more reliable.

decoder/faad: check sample_rate, not frames_per_second
6585e185 · Max Kellermann · 6f1b4292 · 6585e185
Commit 6585e185 authored Jul 11, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

FaadDecoderPlugin.cxx src/decoder/FaadDecoderPlugin.cxx +4 -2

No files found.
--- a/src/decoder/FaadDecoderPlugin.cxx
+++ b/src/decoder/FaadDecoderPlugin.cxx
@@ -148,10 +148,12 @@ adts_song_duration(DecoderBuffer *buffer)
 		decoder_buffer_consume(buffer, frame_length);
 	}

-	float frames_per_second = (float)sample_rate / 1024.0;
-	if (frames_per_second <= 0)
+	if (sample_rate == 0)
 		return -1;

+	float frames_per_second = (float)sample_rate / 1024.0;
+	assert(frames_per_second > 0);
+
 	return (float)frames / frames_per_second;
 }