mapper: check "x" permission on music directory

This is a common support case, and hopefully, the new error message will allow the user to understand the error without requiring support.

mapper: check "x" permission on music directory
718e1804 · Max Kellermann · cead5e5b · 718e1804 · 718e1804
Commit 718e1804 authored Nov 28, 2011 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 0 deletions

NEWS NEWS +1 -0

mapper.c src/mapper.c +8 -0

No files found.
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ ver 0.16.6 (2010/??/??)
  - flac, null, wave: fix buffer corruption bug
  - wave: support packed 24 bit samples
 * mapper: fix the bogus "not a directory" error message
+* mapper: check "x" permission on music directory
 * log: print reason for failure
 * event_pipe: fix WIN32 regression
 * define WINVER in ./configure

--- a/src/mapper.c
+++ b/src/mapper.c
@@ -68,6 +68,14 @@ check_directory(const char *path)
 		g_warning("Not a directory: %s", path);
 		return;
 	}
+
+#ifndef WIN32
+	char *x = g_build_filename(path, ".", NULL);
+	if (stat(x, &st) < 0 && errno == EACCES)
+		g_warning("No permission to traverse (\"execute\") directory: %s",
+			  path);
+	g_free(x);
+#endif
 }

 static void