Main: allocate Instance on the stack

src/Idle.cxx

@@ -33,5 +33,5 @@ idle_add(unsigned flags)
 {
 	assert(flags != 0);
 
-	instance->EmitIdle(flags);
+	global_instance->EmitIdle(flags);
 }

src/Main.hxx

@@ -31,7 +31,7 @@ extern Context *context;
 extern LogListener *logListener;
 #endif
 
-extern Instance *instance;
+extern Instance *global_instance;
 
 #ifndef ANDROID
 

src/Mapper.cxx

@@ -66,10 +66,10 @@ map_uri_fs(const char *uri) noexcept
 	assert(uri != nullptr);
 	assert(*uri != '/');
 
-	if (instance->storage == nullptr)
+	if (global_instance->storage == nullptr)
 		return nullptr;
 
-	const auto music_dir_fs = instance->storage->MapFS("");
+	const auto music_dir_fs = global_instance->storage->MapFS("");
 	if (music_dir_fs.IsNull())
 		return nullptr;
 
@@ -84,10 +84,10 @@ std::string
 map_fs_to_utf8(Path path_fs) noexcept
 {
 	if (path_fs.IsAbsolute()) {
-		if (instance->storage == nullptr)
+		if (global_instance->storage == nullptr)
 			return std::string();
 
-		const auto music_dir_fs = instance->storage->MapFS("");
+		const auto music_dir_fs = global_instance->storage->MapFS("");
 		if (music_dir_fs.IsNull())
 			return std::string();
 

src/win32/Win32Main.cxx

@@ -70,7 +70,7 @@ service_dispatcher(gcc_unused DWORD control, gcc_unused DWORD event_type,
 	switch (control) {
 	case SERVICE_CONTROL_SHUTDOWN:
 	case SERVICE_CONTROL_STOP:
-		instance->Break();
+		global_instance->Break();
 		return NO_ERROR;
 	default:
 		return NO_ERROR;
@@ -106,7 +106,7 @@ console_handler(DWORD event)
 			// regardless our thread is still active.
 			// If this did not happen within 3 seconds
 			// let's shutdown anyway.
-			instance->Break();
+			global_instance->Break();
 			// Under debugger it's better to wait indefinitely
 			// to allow debugging of shutdown code.
 			Sleep(IsDebuggerPresent() ? INFINITE : 3000);