flac: use signed integers in flac_convert_stereo16()

By mistake, I casted the sample value to uint16_t, which is wrong. This patch simplifies the code by using a int16_t pointer instead of casting to int16_t* every time.

flac: use signed integers in flac_convert_stereo16()
7486c150 · Max Kellermann · 8bcbe90b · 7486c150
Commit 7486c150 authored Sep 23, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 6 deletions

_flac_common.c src/inputPlugins/_flac_common.c +4 -6

No files found.
--- a/src/inputPlugins/_flac_common.c
+++ b/src/inputPlugins/_flac_common.c
@@ -209,15 +209,13 @@ static inline int flacSendChunk(FlacData * data)
 	return 0;
 }

-static void flac_convert_stereo16(unsigned char *dest,
+static void flac_convert_stereo16(int16_t *dest,
 				  const FLAC__int32 * const buf[],
 				  unsigned int position, unsigned int end)
 {
 	for (; position < end; ++position) {
-		*(uint16_t*)dest = buf[0][position];
-		dest += 2;
-		*(uint16_t*)dest = buf[1][position];
-		dest += 2;
+		*dest++ = buf[0][position];
+		*dest++ = buf[1][position];
 	}
 }

@@ -264,7 +262,7 @@ flac_common_write(FlacData *data, const FLAC__Frame * frame,
 			num_samples = max_samples;

 		if (num_channels == 2 && bytes_per_sample == 2)
-			flac_convert_stereo16(data->chunk,
+			flac_convert_stereo16((int16_t*)data->chunk,
 					      buf, c_samp,
 					      c_samp + num_samples);
 		else