decoder/faad: bit_rate==0 is an error

7556abb9 · Max Kellermann · 9d3a85d4 · 7556abb9
Commit 7556abb9 authored Aug 29, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

FaadDecoderPlugin.cxx src/decoder/plugins/FaadDecoderPlugin.cxx +4 -4

No files found.
--- a/src/decoder/plugins/FaadDecoderPlugin.cxx
+++ b/src/decoder/plugins/FaadDecoderPlugin.cxx
@@ -219,10 +219,10 @@ faad_song_duration(DecoderBuffer *buffer, InputStream &is)
 			(data.data[7 + skip_size] & 0xE0);

 		const auto size = is.GetSize();
-		if (bit_rate != 0)
-			return size * 8.0 / bit_rate;
-		else
-			return size;
+		if (bit_rate == 0)
+			return -1;
+
+		return size * 8.0 / bit_rate;
 	} else
 		return -1;
 }