tag/ApeTag: don't take reference of IterableSplitString() elements

This doesn't work because IterableSplitString() returns its elements by value. Fixes clang warning: loop variable 'i' is always a copy because the range of type 'IterableSplitString' (aka 'BasicIterableSplitString<char>') does not return a reference [-Werror,-Wrange-loop-analysis]

tag/ApeTag: don't take reference of IterableSplitString() elements
7c62887d · Max Kellermann · 3fc859c4 · 7c62887d
Commit 7c62887d authored Feb 04, 2020 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

ApeTag.cxx src/tag/ApeTag.cxx +2 -2

No files found.
--- a/src/tag/ApeTag.cxx
+++ b/src/tag/ApeTag.cxx
@@ -54,14 +54,14 @@ tag_ape_import_item(unsigned long flags,
 		return false;

 	if (handler.WantPair())
-		for (const auto &i : IterableSplitString(value, '\0'))
+		for (const auto i : IterableSplitString(value, '\0'))
 			handler.OnPair(key, i);

 	TagType type = tag_ape_name_parse(key);
 	if (type == TAG_NUM_OF_ITEM_TYPES)
 		return false;

-	for (const auto &i : IterableSplitString(value, '\0'))
+	for (const auto i : IterableSplitString(value, '\0'))
 		handler.OnTag(type, i);

 	return true;