song_save: don't call tag_free(NULL)

When a song was in the database twice (which shouldn't happen), and the first song had no tag items, MPD calledd tag_free(NULL). Add a check to that source location, and an assertion to tag_free().

song_save: don't call tag_free(NULL)
7d9316a5 · Max Kellermann · fd09a3cf · 7d9316a5 · 7d9316a5
Commit 7d9316a5 authored Apr 28, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

song_save.c src/song_save.c +2 -1

tag.c src/tag.c +2 -0

No files found.
--- a/src/song_save.c
+++ b/src/song_save.c
@@ -80,7 +80,8 @@ insertSongIntoList(struct songvec *sv, struct song *newsong)
 			tag_end_add(newsong->tag);
 	} else { /* prevent dupes, just update the existing song info */
 		if (existing->mtime != newsong->mtime) {
-			tag_free(existing->tag);
+			if (existing->tag != NULL)
+				tag_free(existing->tag);
 			if (newsong->tag)
 				tag_end_add(newsong->tag);
 			existing->tag = newsong->tag;

--- a/src/tag.c
+++ b/src/tag.c
@@ -163,6 +163,8 @@ void tag_free(struct tag *tag)
 {
 	int i;

+	assert(tag != NULL);
+
 	g_mutex_lock(tag_pool_lock);
 	for (i = tag->num_items; --i >= 0; )
 		tag_pool_put_item(tag->items[i]);