output/osx: don't restart AudioUnit at the end of Cancel()

We shouldn't restart the AudioUnit while the ring buffer is empty, or else our render callback may emit noise. Closes https://github.com/MusicPlayerDaemon/MPD/issues/771

output/osx: don't restart AudioUnit at the end of Cancel()
80471025 · Max Kellermann · fe5b81e1 · 80471025 · 80471025
Commit 80471025 authored Jul 02, 2020 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +1 -0

OSXOutputPlugin.cxx src/output/plugins/OSXOutputPlugin.cxx +2 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -9,6 +9,7 @@ ver 0.21.25 (not yet released)
  - opus: fix memory leak
 * output
  - osx: improve sample rate selection
+  - osx: fix noise while stopping
 * Windows/Android:
  - fix Boost detection after breaking change in Meson 0.54


--- a/src/output/plugins/OSXOutputPlugin.cxx
+++ b/src/output/plugins/OSXOutputPlugin.cxx
@@ -831,7 +831,8 @@ OSXOutput::Cancel() noexcept
 #ifdef ENABLE_DSD
 	pcm_export->Reset();
 #endif
-	AudioOutputUnitStart(au);
+
+	/* the AudioUnit will be restarted by the next Play() call */
 }

 int