sticker/Database: always invoke sqlite3_reset() and sqlite3_clear_bindings()

80ddf4ae · Max Kellermann · 12b4a666 · 80ddf4ae
Commit 80ddf4ae authored Dec 12, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

StickerDatabase.cxx src/sticker/StickerDatabase.cxx +4 -4

No files found.
--- a/src/sticker/StickerDatabase.cxx
+++ b/src/sticker/StickerDatabase.cxx
@@ -251,14 +251,14 @@ sticker_insert_value(const char *type, const char *uri,
 	if (!BindAll(stmt, type, uri, name, value))
 		return false;

-	if (!ExecuteCommand(stmt))
-		return false;
+	bool success = ExecuteCommand(stmt);

 	sqlite3_reset(stmt);
 	sqlite3_clear_bindings(stmt);

-	idle_add(IDLE_STICKER);
-	return true;
+	if (success)
+		idle_add(IDLE_STICKER);
+	return success;
 }

 bool